Open
Conversation
mandryllo
reviewed
Feb 23, 2026
tests/otel/infrastructure/index.ts
Outdated
Comment on lines
29
to
36
| const cloudWatchLogGroup = new aws.cloudwatch.LogGroup( | ||
| `${appName}-log-group`, | ||
| { | ||
| name: cloudWatchLogGroupName, | ||
| tags, | ||
| }, | ||
| { parent }, | ||
| ); |
Collaborator
There was a problem hiding this comment.
Should this be part of OtelCollectorBuilder?
| export const usersPath = '/users'; | ||
| export const errorPath = '/error'; | ||
|
|
||
| export const prometheusNamespace = 'icb_otel_integration'; |
Collaborator
There was a problem hiding this comment.
Is there a reason why this is snake_case not kebab-case like everything else? 
Member
Author
There was a problem hiding this comment.
Yep, prometheus uses snake case convention for naming even though at first i went with kebab case, i had issues querying metrics...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces OTel integration tests. It provisions a web server and an OTel collector that exports telemetry data to AWS CloudWatch, X-Ray, and Prometheus. The tests validate that telemetry data is successfully delivered to all configured services.